-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BF16 scalar quantizer for faiss #570
Conversation
Signed-off-by: Alexandr Guzhva <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alexanderguzhva The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
=========================================
+ Coverage 0 70.04% +70.04%
=========================================
Files 0 67 +67
Lines 0 4597 +4597
=========================================
+ Hits 0 3220 +3220
- Misses 0 1377 +1377 |
Are we trying to align the code with FAISS? If so why we don't just pull new versions? |
I do it from time to time, while cherry-picking the most important PRs asap |
@liliu-z fyi, faiss has committed this PR to the baseline |
superseded by #663 |
Corresponding faiss PR: facebookresearch/faiss#3444
/kind improvement