Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BF16 scalar quantizer for faiss #570

Closed
wants to merge 1 commit into from

Conversation

alexanderguzhva
Copy link
Collaborator

Corresponding faiss PR: facebookresearch/faiss#3444

/kind improvement

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexanderguzhva
To complete the pull request process, please assign hhy3 after the PR has been reviewed.
You can assign the PR to them by writing /assign @hhy3 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (3c46f4c) to head (8d5e05c).
Report is 96 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #570       +/-   ##
=========================================
+ Coverage      0   70.04%   +70.04%     
=========================================
  Files         0       67       +67     
  Lines         0     4597     +4597     
=========================================
+ Hits          0     3220     +3220     
- Misses        0     1377     +1377     

see 67 files with indirect coverage changes

@liliu-z
Copy link
Collaborator

liliu-z commented May 20, 2024

Are we trying to align the code with FAISS? If so why we don't just pull new versions?

@alexanderguzhva
Copy link
Collaborator Author

I do it from time to time, while cherry-picking the most important PRs asap

@alexanderguzhva
Copy link
Collaborator Author

@liliu-z fyi, faiss has committed this PR to the baseline

@github-actions github-actions bot added the stale label Jun 23, 2024
@mergify mergify bot removed the ci-passed label Jun 23, 2024
@alexanderguzhva
Copy link
Collaborator Author

superseded by #663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants