Image: Fix shortcut key not work at second time issue (ElemeFE#18983) (…

…ElemeFE#19156) * Image: fix shortcut key not work at second time issue (ElemeFE#18983) * fix test case * fix test case Co-authored-by: cl199793 <[email protected]>
zihe-xu · Jun 27, 2020 · 50368c5 · 50368c5
1 parent 46ef91c
commit 50368c5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/image/src/main.vue b/packages/image/src/main.vue
@@ -16,7 +16,7 @@
       :style="imageStyle"
       :class="{ 'el-image__inner--center': alignCenter, 'el-image__preview': preview }">
     <template v-if="preview">
-      <image-viewer :z-index="zIndex" :initial-index="imageIndex" v-show="showViewer" :on-close="closeViewer" :url-list="previewSrcList"/>
+      <image-viewer :z-index="zIndex" :initial-index="imageIndex" v-if="showViewer" :on-close="closeViewer" :url-list="previewSrcList"/>
     </template>
   </div>
 </template>

diff --git a/test/unit/specs/image.spec.js b/test/unit/specs/image.spec.js
@@ -128,11 +128,10 @@ describe('Image', () => {
     vm.$el.querySelector('.el-image__inner').click();
     await wait();
 
-    const $wrapper = vm.$el.querySelector('.el-image-viewer__wrapper');
-    expect($wrapper).to.exist;
+    expect(vm.$el.querySelector('.el-image-viewer__wrapper')).to.exist;
     vm.$el.querySelector('.el-image-viewer__close').click();
     await wait(1000);
-    expect($wrapper.style.display).to.equal('none');
+    expect(vm.$el.querySelector('.el-image-viewer__wrapper')).to.not.exist;
   });
 });