Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build on windows with latest Zig master #483

Closed
genejo opened this issue May 3, 2022 · 4 comments · Fixed by #496
Closed

Can't build on windows with latest Zig master #483

genejo opened this issue May 3, 2022 · 4 comments · Fixed by #496

Comments

@genejo
Copy link

genejo commented May 3, 2022

I'm trying to call zig build -Drelease-safe. Zig is latest master (2022-05-02), but it fails. Does anyone know what I may be missing?

c:\bin\zls>zig version
0.10.0-dev.2033+3679d737f
c:\bin\zls>zig build -Drelease-safe
C:\bin\zls\src\main.zig:1457:48: error: expected error union type, found 'std.child_process.ChildProcess'
        var process = try std.ChildProcess.init(&[_][]const u8{ zig_exe_path, "fmt", "--stdin" }, allocator);
                                               ^
zls...The following command exited with error code 1:
C:\bin\zig-windows-x86_64\zig.exe build-exe C:\bin\zls\src\main.zig -OReleaseSafe --cache-dir C:\bin\zls\zig-cache --global-cache-dir C:\Users\eugen\AppData\Local\zig --name zls --pkg-begin build_options C:\bin\zls\zig-cache\options\H9AR0LKhRsNLPCkAU3kSn-zvYq8-9gC59lDnXgE_CH0psH885s1rdv7SSsAB5aNT --pkg-end --pkg-begin known-folders C:\bin\zls\src\known-folders\known-folders.zig --pkg-end --pkg-begin zinput C:\bin\zls\src\zinput\src\main.zig --pkg-end --enable-cache
error: the following build command failed with exit code 1:
c:\bin\zls\zig-cache\o\402843ed16b3807462781bae6796feb9\build.exe C:\bin\zig-windows-x86_64\zig.exe c:\bin\zls c:\bin\zls\zig-cache C:\Users\eugen\AppData\Local\zig -Drelease-safe

Also tried with -Ddata_version=master.

@nektro
Copy link
Contributor

nektro commented May 3, 2022

fixed with #481

@genejo genejo closed this as completed May 3, 2022
@tpeacock19
Copy link

I'm still unable to build this on arch linux. It shows the same error as the github actions here: https://github.com/zigtools/zls/actions/runs/2297826191

@jesselucas
Copy link

Same error on debian 11
./src/main.zig:1457:48: error: expected error union type, found 'std.child_process.ChildProcess'

@nektro
Copy link
Contributor

nektro commented May 22, 2022

yeah that pull is still open, this issue shouldnt be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants