Refactored PKI Keeper to reduce code duplication #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artemkaaas
force-pushed
the
refactoring
branch
from
6465495
to
058bfb2
Compare
Artemkaaas
force-pushed
the
refactoring
branch
from
a235bc0
to
a8b8d35
Compare
Artemkaaas
force-pushed
the
refactoring
branch
from
6611664
to
40d26b7
Compare
| * Negative: | ||
| * TBD | ||
|
|
||
| ## [Revoke DA Root](./handler_revoke_paa_cert_test.go) |
There was a problem hiding this comment.
Can you please analyze tests for remove/revoke by SerialNumber (at least simple cases)?
ashcherbakov
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.