-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#524 Enable revocation of NOC root certificates #550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdulbois
force-pushed
the
#524-Revocation-of-NOC-root-certs
branch
4 times, most recently
from
March 13, 2024 06:55
d234cde
to
4a923c5
Compare
Abdulbois
force-pushed
the
#524-Revocation-of-NOC-root-certs
branch
3 times, most recently
from
March 13, 2024 07:22
0af9eb1
to
69aa8ee
Compare
Abdulbois
changed the title
#524 Revocation of NOC root certificates
#524 Enable Revocation of NOC root certificates
Mar 13, 2024
Abdulbois
changed the title
#524 Enable Revocation of NOC root certificates
#524 Enable revocation of NOC root certificates
Mar 13, 2024
Enable revoking NOC Root certs Signed-off-by: Abdulbois <[email protected]> Signed-off-by: Abdulbois <[email protected]>
Abdulbois
force-pushed
the
#524-Revocation-of-NOC-root-certs
branch
from
March 13, 2024 08:53
69aa8ee
to
bd7df90
Compare
akarabashov
reviewed
Mar 14, 2024
integration_tests/cli/pki-noc-revocation-with-revoking-child.sh
Outdated
Show resolved
Hide resolved
integration_tests/cli/pki-noc-revocation-with-revoking-child.sh
Outdated
Show resolved
Hide resolved
integration_tests/cli/pki-noc-revocation-with-revoking-child.sh
Outdated
Show resolved
Hide resolved
Abdulbois
force-pushed
the
#524-Revocation-of-NOC-root-certs
branch
3 times, most recently
from
March 14, 2024 12:16
2b10f5e
to
1981ae6
Compare
akarabashov
approved these changes
Mar 15, 2024
akarabashov
reviewed
Mar 15, 2024
akarabashov
reviewed
Mar 15, 2024
akarabashov
reviewed
Mar 15, 2024
Abdulbois
force-pushed
the
#524-Revocation-of-NOC-root-certs
branch
from
March 15, 2024 09:52
1981ae6
to
6522d44
Compare
Minor refactoring due to comments of PR Signed-off-by: Abdulbois <[email protected]> Signed-off-by: Abdulbois <[email protected]>
Abdulbois
force-pushed
the
#524-Revocation-of-NOC-root-certs
branch
from
March 15, 2024 10:39
6522d44
to
bb8407f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable revoking NOC X509 Root certificates