Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#303 Upgrade Cosmos SDK #536

Merged
merged 35 commits into from
May 2, 2024
Merged

#303 Upgrade Cosmos SDK #536

merged 35 commits into from
May 2, 2024

Conversation

Abdulbois
Copy link
Collaborator

@Abdulbois Abdulbois commented Jan 25, 2024 •
edited
Loading

  • Upgrade Cosmos SDK to v0.47.8 version
  • Upgrade Golang to 1.20 version
  • Add buf.yaml files to manage generation of .pb, .ts and openApi.yaml files
  • Generate frontend related ts-client folder

@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.3
f0a142e 
Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.3
153cb7b 
Change package names

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.3
c5ece4d 
FIx linter errors

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.3
f6b40e9 
Update docker files

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.3
ed4bd87 
- Update version of linter
- Fix linter errors

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois Abdulbois force-pushed the #303-Upgrade-Cosmos-SDK branch 2 times, most recently from 6f6d429 to 854b173 Compare January 29, 2024 09:12
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.3
a195ea8 
- Update version of linter

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.3
43e0a4c 
- Update `cosmovisor start` command

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.3
b6944c9 
- Update `broadcast-mode` to `sync`

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.3
e9279cc 
- Run only 'grpc rest' integration tests

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.3
f0b559f 
- Fix unit tests
- Modify BroadcastTx of grpc integration tests due to cosmos-sdk API changes

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.3
2552f31 
- Fix unit tests
- Update versions of deps

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois Abdulbois force-pushed the #303-Upgrade-Cosmos-SDK branch 3 times, most recently from bb0167d to 3696139 Compare February 1, 2024 10:13
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.3
bd62778 
- Modify BroadcastTx method
- Enable external access of REST and gRPC endpoints

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois Abdulbois force-pushed the #303-Upgrade-Cosmos-SDK branch 6 times, most recently from 37c6621 to b01d163 Compare February 3, 2024 08:43
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.3
f672d50 
- Add extra line into shell tests to get `txn` status

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois Abdulbois force-pushed the #303-Upgrade-Cosmos-SDK branch 3 times, most recently from 4cf1027 to 548c2af Compare February 5, 2024 07:36
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.8
3eff4e7 
- Setup Validator node with latest binary

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois Abdulbois force-pushed the #303-Upgrade-Cosmos-SDK branch 6 times, most recently from e2ac1b3 to f41bd43 Compare April 18, 2024 14:46
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.8
576f325 
- Fix Validator node cli tests

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.8
d606863 
- Update docs and helper scripts
- Revert Ansible CI changes

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois Abdulbois marked this pull request as ready for review April 19, 2024 14:51
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.8
f562122 
- Fix CI lint errors
- Temporary disable Molecule actionlint job

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@Abdulbois Abdulbois force-pushed the #303-Upgrade-Cosmos-SDK branch 3 times, most recently from 3a7aa57 to b061ce7 Compare April 22, 2024 14:06
@Abdulbois
Merge branch 'master' into #303-Upgrade-Cosmos-SDK
79c2f3a 
Signed-off-by: Abdulbois <[email protected]>

# Conflicts:
#	proto/zigbeealliance/distributedcomplianceledger/pki/genesis.proto
#	proto/zigbeealliance/distributedcomplianceledger/pki/noc_root_certificates_by_vid_and_skid.proto
#	proto/zigbeealliance/distributedcomplianceledger/pki/query.proto
#	x/pki/types/genesis.pb.go
#	x/pki/types/query.pb.go
@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.8
6c5aa27 
Add CHANGELOG.md file

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
akarabashov
akarabashov reviewed Apr 26, 2024
View reviewed changes
docs/how-to.md Outdated
@@ -47,7 +47,8 @@ Here is the list of supported settings:
- `chain-id <chain id>` - unique chain ID of the network you are going to connect to
- `output <type>` - Output format (text/json)
- `node <node-ip>` - Address `<host>:<port>` of the node to connect.
- `broadcast-mode <mode>` - Write transaction broadcast mode to use (one of: `sync`, `async`, `block`. `block` is default).
- `broadcast-mode <mode>` - Write transaction broadcast mode to use (one of: `sync`, `async`. `sync` is default).
- Note: In `sync` broadcast mode, to get the actual result of transaction(`dcld tx ..`) one more query call with `txHash` must be executed(`dcld query tx=txHash`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Note: In `sync` broadcast mode, to get the actual result of transaction(`dcld tx ..`) one more query call with `txHash` must be executed(`dcld query tx=txHash`)
- Note: To get the actual result of transaction(`dcld tx ..`) one more query call with `txHash` must be executed(`dcld query tx=txHash`)

akarabashov
akarabashov reviewed Apr 26, 2024
View reviewed changes
docs/running-light-client-proxy.md Outdated

Please note, that CLI can use a Light Client proxy only for single-value query requests.
A Full Node (Validator or Observer) should be used for multi-value query requests and write requests.

See the following links for details about a Light Client:

- <https://docs.tendermint.com/v0.34/tendermint-core/light-client.html>
- <https://docs.cometbft.com/main/explanation/core/light-client>
Copy link
Collaborator

@akarabashov akarabashov Apr 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- <https://docs.cometbft.com/main/explanation/core/light-client>
- <https://docs.cometbft.com/v0.37/core/light-client>

akarabashov
akarabashov reviewed Apr 26, 2024
View reviewed changes
docs/running-light-client-proxy.md Outdated
@@ -21,7 +21,7 @@ dcld config node tcp://<light-client-proxy-host>:8888

## Running Light Client Proxy - Detailed

See <https://docs.tendermint.com/v0.34/tendermint-core/light-client.html> for details
See <https://docs.cometbft.com/main/explanation/core/light-client> for details
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See <https://docs.cometbft.com/main/explanation/core/light-client> for details
See <https://docs.cometbft.com/v0.37/core/light-client> for details

akarabashov
akarabashov reviewed Apr 26, 2024
View reviewed changes
genlocalnetconfig.sh Outdated
# Make REST endpoints available externally
sed -i $SED_EXT 's/address = "tcp:\/\/localhost:1317"/address = "tcp:\/\/0.0.0.0:1317"/g' "$LOCALNET_DIR/${node_name}/config/app.toml"
# Make gRPC endpoints available externally
sed -i $SED_EXT 's/address = "localhost:9090"/address = "0.0.0.0:9090"/g' "$LOCALNET_DIR/${node_name}/config/app.toml"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines are duplicated, see below

akarabashov
akarabashov reviewed Apr 26, 2024
View reviewed changes
scripts/README.md

```bash
starport chain build
./scripts/protocgen.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add that we can also use the ignite chain build command.

@Abdulbois
#303 Upgrade Cosmos-SDK to v0.47.8
a7c4b32 
Fix docs

Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]>
@akarabashov akarabashov merged commit cd4614e into master May 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcherbakov ashcherbakov ashcherbakov left review comments

@akarabashov akarabashov akarabashov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abdulbois @ashcherbakov @akarabashov