Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion on Test Coverage in Domain Layer #75

Open
coderabbitai bot opened this issue Nov 27, 2024 · 0 comments
Open

Discussion on Test Coverage in Domain Layer #75

coderabbitai bot opened this issue Nov 27, 2024 · 0 comments
Assignees

Comments

@coderabbitai
Copy link

coderabbitai bot commented Nov 27, 2024

This issue is created based on the conversation in PR #73 at this comment.

User @zhumeisongsong would like to discuss the purpose and value of adding tests in the domain layer, specifically related to email validation in libs/users/domain/src/lib/user.entity.spec.ts.

The discussion focuses on whether it's appropriate to add tests in the domain layer when validation logic resides in the infrastructure layer (e.g., Mongoose schemas). The goal is to determine the best practices for test placement in relation to where the corresponding logic is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant