Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems that bipe_alibi is not working yet. #1

Open
liveck opened this issue Jun 18, 2024 · 1 comment
Open

It seems that bipe_alibi is not working yet. #1

liveck opened this issue Jun 18, 2024 · 1 comment

Comments

@liveck
Copy link

liveck commented Jun 18, 2024

It seems that bipe_alibi is not working yet.

get_ape_embeddings returns a tuple, which is different from embed_tokens.

All codes since here do not work.

if self.config.rpe_type == "bipe_alibi":
    inputs_embeds = self.get_ape_embeddings(torch.stack([input_ids, token_ids], dim=-1))
else:
    inputs_embeds = self.embed_tokens(input_ids)
@zhenyuhe00
Copy link
Owner

zhenyuhe00 commented Jun 18, 2024

Hi,
Sorry about the typo in get_ape_embeddings and thanks for pointing this out.

It should be return embed rather than return embed, X[:, :, 0].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants