From d7c1cce74b95d75b90fd0a9664e72fb45d5e0a96 Mon Sep 17 00:00:00 2001
From: Yongjie Zhao <yongjie.zhao@gmail.com>
Date: Mon, 4 Oct 2021 06:28:55 +0100
Subject: [PATCH] fix: replace absolute difference with difference in legacy
 charts (#1384)

---
 .../legacy-plugin-chart-partition/src/controlPanel.tsx        | 4 ++--
 .../plugins/legacy-plugin-chart-rose/src/controlPanel.tsx     | 4 ++--
 .../plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx     | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-plugin-chart-partition/src/controlPanel.tsx b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-plugin-chart-partition/src/controlPanel.tsx
index 3f6a7c9aa5213..8c213960352dc 100644
--- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-plugin-chart-partition/src/controlPanel.tsx
+++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-plugin-chart-partition/src/controlPanel.tsx
@@ -315,13 +315,13 @@ const config: ControlPanelConfig = {
               default: 'values',
               choices: [
                 ['values', 'Actual Values'],
-                ['absolute', 'Absolute difference'],
+                ['absolute', 'Difference'],
                 ['percentage', 'Percentage change'],
                 ['ratio', 'Ratio'],
               ],
               description: t(
                 'How to display time shifts: as individual lines; as the ' +
-                  'absolute difference between the main time series and each time shift; ' +
+                  'difference between the main time series and each time shift; ' +
                   'as the percentage change; or as the ratio between series and time shifts.',
               ),
             },
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-plugin-chart-rose/src/controlPanel.tsx b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-plugin-chart-rose/src/controlPanel.tsx
index e4486fef41b69..960ce13726ba2 100644
--- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-plugin-chart-rose/src/controlPanel.tsx
+++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-plugin-chart-rose/src/controlPanel.tsx
@@ -210,13 +210,13 @@ const config: ControlPanelConfig = {
               default: 'values',
               choices: [
                 ['values', 'Actual Values'],
-                ['absolute', 'Absolute difference'],
+                ['absolute', 'Difference'],
                 ['percentage', 'Percentage change'],
                 ['ratio', 'Ratio'],
               ],
               description: t(
                 'How to display time shifts: as individual lines; as the ' +
-                  'absolute difference between the main time series and each time shift; ' +
+                  'difference between the main time series and each time shift; ' +
                   'as the percentage change; or as the ratio between series and time shifts.',
               ),
             },
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx
index e43b224c602d2..359aa29c8fab1 100644
--- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx
+++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx
@@ -458,13 +458,13 @@ export const timeSeriesSection: ControlPanelSectionConfig[] = [
             default: 'values',
             choices: [
               ['values', 'Actual Values'],
-              ['absolute', 'Absolute difference'],
+              ['absolute', 'Difference'],
               ['percentage', 'Percentage change'],
               ['ratio', 'Ratio'],
             ],
             description: t(
               'How to display time shifts: as individual lines; as the ' +
-                'absolute difference between the main time series and each time shift; ' +
+                'difference between the main time series and each time shift; ' +
                 'as the percentage change; or as the ratio between series and time shifts.',
             ),
           },