Skip to content

Commit

Permalink
[KYUUBI apache#5529][AUTHZ][FOLLOWUP] Remove useless org.apache.spark…
Browse files Browse the repository at this point in the history
….sql.delta.commands.CreateDeltaTableCommand

### _Why are the changes needed?_
To close apache#5529 .
Remove useless `org.apache.spark.sql.delta.commands.CreateDeltaTableCommand`.

Because the logical plans for Delta Lake create table and replace table are `org.apache.spark.sql.catalyst.plans.logical.CreateTable`, `org.apache.spark.sql.catalyst.plans.logical.CreateV2Table` and `org.apache.spark.sql.catalyst.plans.logical.ReplaceTable`.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_
No.

Closes apache#5571 from zml1206/KYUUBI-5529-FOLLOWUP.

Closes apache#5529

0908571 [zml1206] Remove useless org.apache.spark.sql.delta.commands.CreateDeltaTableCommand

Authored-by: zml1206 <[email protected]>
Signed-off-by: Fu Chen <[email protected]>
  • Loading branch information
zml1206 authored and cfmcgrady committed Nov 1, 2023
1 parent 591250c commit 9cda08b
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 49 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1968,19 +1968,4 @@
"opType" : "QUERY",
"queryDescs" : [ ],
"uriDescs" : [ ]
}, {
"classname" : "org.apache.spark.sql.delta.commands.CreateDeltaTableCommand",
"tableDescs" : [ {
"fieldName" : "table",
"fieldExtractor" : "CatalogTableTableExtractor",
"columnDesc" : null,
"actionTypeDesc" : null,
"tableTypeDesc" : null,
"catalogDesc" : null,
"isInput" : false,
"setCurrentDatabaseIfMissing" : false
} ],
"opType" : "CREATETABLE",
"queryDescs" : [ ],
"uriDescs" : [ ]
} ]

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class JsonSpecFileGenerator extends AnyFunSuite {
// scalastyle:on
test("check spec json files") {
writeCommandSpecJson("database", Seq(DatabaseCommands))
writeCommandSpecJson("table", Seq(TableCommands, IcebergCommands, HudiCommands, DeltaCommands))
writeCommandSpecJson("table", Seq(TableCommands, IcebergCommands, HudiCommands))
writeCommandSpecJson("function", Seq(FunctionCommands))
writeCommandSpecJson("scan", Seq(Scans))
}
Expand Down

0 comments on commit 9cda08b

Please sign in to comment.