Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep in sync with GoogleChrome/custom-tabs-client #2

Open
zhanghai opened this issue Aug 16, 2016 · 3 comments
Open

Keep in sync with GoogleChrome/custom-tabs-client #2

zhanghai opened this issue Aug 16, 2016 · 3 comments
Assignees

Comments

@zhanghai
Copy link
Owner

zhanghai commented Aug 16, 2016

https://github.com/GoogleChrome/custom-tabs-client

@zhanghai zhanghai self-assigned this Aug 16, 2016
@zhanghai
Copy link
Owner Author

Up-to-date as of 2016-10-25.

@zhanghai zhanghai changed the title Sync with GoogleChrome/custom-tabs-client Keep in sync with GoogleChrome/custom-tabs-client Oct 24, 2016
@NoahAndrews
Copy link
Contributor

NoahAndrews commented Aug 12, 2017

Despite the fact that there is a new commit that changes something in the shared directory, it is only an update to the custom tabs support library itself, and one of the activities in the sample. The only change to the shared directory is an extra import line.

That being said, it may be worthwhile to have this library register a BroadcastReceiver for the BrowserActions intent, and allow the user to specify a simple callback for when one of the menu options in the custom tab is selected. That commit does provide an example for handling that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants