Bug fixes and updates (#95) #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update dependencies * apply strict linter - conflict * Workaround for NPE, ignore IDE project files. * Bump version, upgrade dependencies. * Ignored files cleanup. * More deleted files. * Delete flutter_plugin_pdf_viewer.iml * More Eclipse artifacts cleanup. * Update Gradle dependencies. * Upgrade old Flutter embedding. * Upgrade Flutter embedding. * Better error logging, maybe properly time cache deletion. * Make sure file is closed when done. * Make sure file is closed when done, better this time. * Use initFileURLWithPath to create a valid file path The NSURL init method initFileURLWithPath will ensure that the file:/// prefix is in place as well as making sure that any whitespace characters within the original path string are encoded correctly when creating the url. * Release implicitly retained CGPDFDocument and release retained CGPDFPage * Update pubspec.yaml * Update pubspec.yaml * Pn 53 (#94) * I removed the line from 42 to 63 for deleting unused saved cache files. It makes memory problem when you try to open the PDF after several times. * remove .idea folder Co-authored-by: Eko Prasetyo <[email protected]> * more fixes and updates * updates * fixes for state problems * upgrade ersion number * update * bug fixes Co-authored-by: Ahmed Masoud <[email protected]> Co-authored-by: Ahmed Masoud <[email protected]> Co-authored-by: Enver ALTIN <[email protected]> Co-authored-by: Robert Hillary <[email protected]> Co-authored-by: Eko Prasetyo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update dependencies
apply strict linter - conflict
Workaround for NPE, ignore IDE project files.
Bump version, upgrade dependencies.
Ignored files cleanup.
More deleted files.
Delete flutter_plugin_pdf_viewer.iml
More Eclipse artifacts cleanup.
Update Gradle dependencies.
Upgrade old Flutter embedding.
Upgrade Flutter embedding.
Better error logging, maybe properly time cache deletion.
Make sure file is closed when done.
Make sure file is closed when done, better this time.
Use initFileURLWithPath to create a valid file path
The NSURL init method initFileURLWithPath will ensure that the file:/// prefix is in place
as well as making sure that any whitespace characters within the original path string
are encoded correctly when creating the url.
Release implicitly retained CGPDFDocument and release retained CGPDFPage
Update pubspec.yaml
Update pubspec.yaml
Pn 53 (Pn 53 lohanidamodar/pdf_viewer#94)
I removed the line from 42 to 63 for deleting unused saved cache files.
It makes memory problem when you try to open the PDF after several times.
remove .idea folder
Co-authored-by: Eko Prasetyo [email protected]
more fixes and updates
updates
fixes for state problems
upgrade ersion number
update
bug fixes
Co-authored-by: Ahmed Masoud [email protected]
Co-authored-by: Ahmed Masoud [email protected]
Co-authored-by: Enver ALTIN [email protected]
Co-authored-by: Robert Hillary [email protected]
Co-authored-by: Eko Prasetyo [email protected]