Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

cast of function pointer should not be allowed #139

Open
mb64 opened this issue Oct 13, 2020 · 1 comment
Open

cast of function pointer should not be allowed #139

mb64 opened this issue Oct 13, 2020 · 1 comment

Comments

@mb64
Copy link

mb64 commented Oct 13, 2020

It would be helpful to know how much typechecking is done by ZZ. I was under the impression it did full typechecking, so I was surprised to find that the following program transpiled to C without error:

using <stdio.h>::{printf};

fn output(int *x) {
    printf("%d\n", *x);
}

fn function() {}

export fn main() -> int {
    output(function);
}

Of course, clang halted compilation with an error. Either way, it would help to clarify in the documentation about typechecking.

@aep
Copy link
Collaborator

aep commented Oct 13, 2020

so there's multiple answers to this.

First of all zetz doesn't have a type checker. Let me know what wording sounded like it does, so we can fix that.

On the issue of this being an invalid cast. Zetz is a prove assistant for C. You can cast anything into anything as long as you don't violate any smt models. Since there aren't any, this passes.

However, zetz is supposed to catch UB by default, and this is UB, so this is still a bug. The issue is a) that printf is completely unconstrained until someone writes a model for it, but also b) a function pointer is unconstrained for backwards compat with union casts, which i havent figured out yet..

@aep aep changed the title Clarify state of typechecker cast of function pointer should not be allowed Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants