Fixed replacement for windows URLs, issue #331 #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure if the test has something to do with the change I made, but I will investigate |
mdobson
reviewed
Jan 7, 2017
| @@ -20,6 +20,7 @@ var deviceFormatter = require('./api_formats/siren/device.siren'); | |||
| var rels = require('zetta-rels'); | |||
|
|
|||
| var querytopic = require('./query_topic'); | |||
| console.log(url); | |||
There was a problem hiding this comment.
Be sure to remove this log statement when you get a chance :) Otherwise looking good pending that issue with a test.
There was a problem hiding this comment.
yeah sorry for that, just saw it too while executing the tests and was wonder where the heck it came from :)
|
There you go lad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried it on my windows machine and it works like a charme now!