VirtualDevice expose .available() #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erties() with tests
| @@ -121,6 +121,27 @@ VirtualDevice.prototype.call = function(/* transition, args, cb */) { | |||
|
|
|||
| }; | |||
|
|
|||
| VirtualDevice.prototype.available = function(transition) { | |||
| return !!this._getAction(transition); | |||
There was a problem hiding this comment.
Because the list of actions is eventually consistent, there's always a chance of this being out-of-sync. Do we propagate a "Transition Not Available" error through virtual devices?
There was a problem hiding this comment.
It gets returned in the callback function when you use .call.
AdamMagaluk
changed the title
|
+1 |
AdamMagaluk
added a commit
that referenced
this pull request
Jan 20, 2016
VirtualDevice expose .available()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
available()on VirtualDevice to match methods exposed on Device. Fixes #278.available()returns state based on what the cloud thinks the state of the device is on a hub getting info from logs topic stream and the return from a transition call. There could be times where the state does not line up.