Added watchdog for ping going into the peer_client. #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…een after 30sec disconnect ws and reconnect
|
Looks like a good approach to me. |
|
I think this is the best approach we can do today. There may be a different option when we upgrade to the 2.0 branch of the spdy library. Thanks for whipping this together. |
AdamMagaluk
added a commit
that referenced
this pull request
Oct 26, 2015
Added watchdog for ping going into the peer_client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no pings are seen coming from the cloud after 30sec disconnect ws and reconnect. Monkey patch is kinda shitty but I couldn't find another way with how spdy doesn't expose the abstract connection that emits ping. Still gotta at some tests.
What's your thoughts on this approach? @mdobson @kevinswiber