Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle peer's spdy agent error event #138

Merged
merged 2 commits into from
Jan 30, 2015
Merged

Handle peer's spdy agent error event #138

merged 2 commits into from
Jan 30, 2015

Conversation

AdamMagaluk
Copy link
Collaborator

See #137

@AdamMagaluk
Copy link
Collaborator Author

Not sure if there is a good way to properly test this. Any thoughts @mdobson

@mdobson
Copy link
Contributor

mdobson commented Jan 30, 2015

You could emit the "error" event on this.agent I suppose.

@mdobson
Copy link
Contributor

mdobson commented Jan 30, 2015

then check that the same error is emitted by the peer_socket object.

@mdobson
Copy link
Contributor

mdobson commented Jan 30, 2015

#mergeit

AdamMagaluk added a commit that referenced this pull request Jan 30, 2015
@AdamMagaluk
Merge pull request #138 from zettajs/handle-peer-agent-error
6be4412 
Handle peer's spdy agent error event
@AdamMagaluk AdamMagaluk merged commit 6be4412 into master Jan 30, 2015
@AdamMagaluk AdamMagaluk deleted the handle-peer-agent-error branch January 30, 2015 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamMagaluk @mdobson