Peering updates #125
Peering updates #125
Conversation
|
This is ready for review if someone can take a look at it. Going over it multiple times would probably be best. This thing is kind of large. |
| req.pipe(request); | ||
| } | ||
| }; | ||
|
|
||
| PeerManagementResource.prototype._connect = function(peer) { |
There was a problem hiding this comment.
Can this whole function be replaced by the .link on zetta that we added yesterday?
There was a problem hiding this comment.
This functionality isn't for linking. It's for proxying peering commands from an acceptor peer to an initiator peer. This uses a fire and forget request because we can't reliably listen for a response back up the pipe.
There was a problem hiding this comment.
I'm referring to PeerManagementResource.prototype._connect = function(peer) { must of highlighted the wrong code.
There was a problem hiding this comment.
We could but that would mean on process restarts links created in the API would be ignored. If we expose runPeer as a function that can be called that would be exactly what I need instead of _connect.
…onnectionId, use ._runPeer on zetta to start a PeerClient.
|
After that long process i think its ready to be green lit. Merge away. Signed-off: Adam T Magaluk |
|
|
WIP
Here is what is done though.