-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove test and scripts from coverage #291
Conversation
WalkthroughThe recent updates to the project focus on enhancing testing and coverage processes by modifying the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
===========================================
+ Coverage 53.39% 68.44% +15.04%
===========================================
Files 16 7 -9
Lines 427 244 -183
Branches 111 61 -50
===========================================
- Hits 228 167 -61
+ Misses 196 76 -120
+ Partials 3 1 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
v2/yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (1)
- v2/package.json (1 hunks)
Additional comments not posted (2)
v2/package.json (2)
14-14
: LGTM! The coverage script update is appropriate.The inclusion of the
--no-match-coverage
option to filter out files matching the patterns(script|test)
aligns with the PR objectives to exclude certain files from coverage reporting.
20-20
: LGTM! The new dependency addition is appropriate.The addition of the
@openzeppelin/upgrades-core
dependency addresses the issue with tests version 2 failing intermittently due to its absence.Ensure that the dependency is used correctly in the codebase.
also fixes tests v2 failing sometimes due to missing openzep upgrade-core package, adding it in dev deps hopefully should fix this issue, will monitor
added issue to increase coverage #292
70% is good, but we can add more tests i think
Summary by CodeRabbit
New Features
Bug Fixes