Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove test and scripts from coverage #291

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Aug 6, 2024

also fixes tests v2 failing sometimes due to missing openzep upgrade-core package, adding it in dev deps hopefully should fix this issue, will monitor

added issue to increase coverage #292
70% is good, but we can add more tests i think

Summary by CodeRabbit

  • New Features

    • Added a new dependency to enhance functionality related to upgradeable contracts.
  • Bug Fixes

    • Improved coverage reporting by filtering out irrelevant files from the coverage analysis.

Copy link
Contributor

coderabbitai bot commented Aug 6, 2024

Walkthrough

The recent updates to the project focus on enhancing testing and coverage processes by modifying the coverage script in the package.json file. The introduction of the @openzeppelin/upgrades-core dependency aims to enrich functionalities related to upgradeable contracts. These changes streamline the coverage reporting, ensuring it emphasizes relevant files and supports future enhancements.

Changes

Files Change Summary
v2/package.json Updated coverage script with --no-match-coverage option; added new dependency @openzeppelin/upgrades-core v1.35.0

Poem

In the garden where code does grow,
A rabbit hops, and the changes flow.
With coverage trimmed, we leap with glee,
New tools to help, oh, what a spree!
Upgrades await, like carrots bright,
Coding adventures, a joyful flight! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.44%. Comparing base (141f951) to head (c1d2f73).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #291       +/-   ##
===========================================
+ Coverage   53.39%   68.44%   +15.04%     
===========================================
  Files          16        7        -9     
  Lines         427      244      -183     
  Branches      111       61       -50     
===========================================
- Hits          228      167       -61     
+ Misses        196       76      -120     
+ Partials        3        1        -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skosito skosito linked an issue Aug 6, 2024 that may be closed by this pull request
@skosito skosito marked this pull request as ready for review August 6, 2024 16:58
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 94516b3 and 267d4e0.

Files ignored due to path filters (1)
  • v2/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing (1)
  • v2/package.json (1 hunks)
Additional comments not posted (2)
v2/package.json (2)

14-14: LGTM! The coverage script update is appropriate.

The inclusion of the --no-match-coverage option to filter out files matching the patterns (script|test) aligns with the PR objectives to exclude certain files from coverage reporting.


20-20: LGTM! The new dependency addition is appropriate.

The addition of the @openzeppelin/upgrades-core dependency addresses the issue with tests version 2 failing intermittently due to its absence.

Ensure that the dependency is used correctly in the codebase.

@skosito skosito merged commit 6ebb9e6 into main Aug 6, 2024
9 checks passed
@skosito skosito deleted the remove-test-from-coverage branch August 6, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove test for code coverage on CodeCov
4 participants