Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor code fixes for ZEL-13 #634

Merged
merged 3 commits into from
May 22, 2023
Merged

fix: minor code fixes for ZEL-13 #634

merged 3 commits into from
May 22, 2023

Conversation

aldapp7
Copy link
Contributor

@aldapp7 aldapp7 commented May 22, 2023

Description

Minor code fixes for ZEL-13:

  1. Remove comments for RemoveForeignCoin as its a working implementation
  2. Remove comments for AddObserver method (potentially remove whole method and update this PR depending on convo in the issue)
  3. Remove unreachable else in crosschain keeper NonceVoter.
  4. Might push some additional small fixes into this PR.

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@aldapp7 aldapp7 self-assigned this May 22, 2023
@aldapp7 aldapp7 marked this pull request as ready for review May 22, 2023 13:08
brewmaster012
brewmaster012 approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@brewmaster012 brewmaster012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldapp7 aldapp7 merged commit e3586b9 into develop May 22, 2023
@aldapp7 aldapp7 deleted the fix/zelic_code_maturity branch May 22, 2023 17:38
@fadeev fadeev mentioned this pull request Jun 5, 2023
Closed
CharlieMc0 pushed a commit that referenced this pull request Jun 27, 2023
@aldapp7
fix: minor code fixes for ZEL-13 (#634)
414c388
CharlieMc0 pushed a commit that referenced this pull request Jun 27, 2023
@aldapp7
fix: minor code fixes for ZEL-13 (#634)
84e0c7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brewmaster012 brewmaster012 brewmaster012 approved these changes

@kingpinXD kingpinXD Awaiting requested review from kingpinXD kingpinXD is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aldapp7 @brewmaster012