Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update protocol contract to check gasleft change #3169

Closed
wants to merge 1 commit into from

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Nov 15, 2024

Description

Implement #3164 but on develop to check the gasleft fix doesn't break on upstream

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain version to go1.22.8.
    • Modified dependency versions for github.com/zeta-chain/protocol-contracts.
    • Added a new dependency: github.com/zeta-chain/protocol-contracts-solana/go-idl.

@lumtis lumtis added no-changelog Skip changelog CI check V2_TESTS Run make start-v2-test labels Nov 15, 2024
Copy link
Contributor

coderabbitai bot commented Nov 15, 2024

📝 Walkthrough

Walkthrough

The go.mod file has been updated to reflect changes in dependency versions. The Go toolchain version has been upgraded from go1.22.7 to go1.22.8. The version of the existing dependency github.com/zeta-chain/protocol-contracts has been modified, and a new dependency github.com/zeta-chain/protocol-contracts-solana/go-idl has been introduced. The overall structure of the require blocks remains unchanged, and indirect dependencies are retained with their original versions.

Changes

File Change Summary
go.mod - Updated Go toolchain version from go1.22.7 to go1.22.8.
- Updated dependency github.com/zeta-chain/protocol-contracts from v1.0.2-athens3.0.20241021075719-d40d2e28467c to v1.0.2-athens3.0.20241115132906-3a2956d37120.
- Added new dependency github.com/zeta-chain/protocol-contracts-solana/go-idl with version v0.0.0-20241108171442-e48d82f94892.

Possibly related PRs

Suggested reviewers

  • skosito
  • kingpinXD
  • ws4charlie
  • brewmaster012
  • fbac
  • swift1337

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lumtis lumtis marked this pull request as draft November 15, 2024 14:29
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
go.mod (1)

Line range hint 3-5: Resolve Go version inconsistency

The Go version (1.22.7) doesn't match the toolchain version (1.22.8). This inconsistency should be resolved to prevent potential build issues.

Apply this diff to align the versions:

-go 1.22.7
+go 1.22.8
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3c22fbb and f77de3b.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (1 hunks)
🔇 Additional comments (3)
go.mod (3)

59-59: Protocol contracts dependency update looks good

The update to the latest version of protocol contracts aligns with the PR objectives.

Also applies to: 59-59


Line range hint 365-382: Replace directives are well-maintained

The replace directives are properly documented and include necessary security fixes and ZetaChain maintained forks.


Line range hint 67-364: Indirect dependencies are properly managed

All indirect dependencies have pinned versions, which is good practice for maintaining reproducible builds.

@lumtis lumtis closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Skip changelog CI check V2_TESTS Run make start-v2-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant