feat: integrate standard memo to Bitcoin inbound and E2E tests

changelog.md

@@ -21,6 +21,7 @@
 * [2987](https://github.com/zeta-chain/node/pull/2987) - add non-EVM standard inbound memo package
 * [2979](https://github.com/zeta-chain/node/pull/2979) - add fungible keeper ability to lock/unlock ZRC20 tokens
 * [3012](https://github.com/zeta-chain/node/pull/3012) - integrate authenticated calls erc20 smart contract functionality into protocol
+* [3025](https://github.com/zeta-chain/node/pull/3025) - standard memo for Bitcoin inbound
 
 ### Refactor
 

cmd/zetae2e/local/local.go

@@ -300,7 +300,12 @@ func localE2ETest(cmd *cobra.Command, _ []string) {
 		bitcoinTests := []string{
 			e2etests.TestBitcoinDepositName,
 			e2etests.TestBitcoinDepositAndCallName,
-			e2etests.TestBitcoinDepositRefundName,
+			e2etests.TestBitcoinDepositAndCallRevertName,
+			e2etests.TestBitcoinDonationName,
+			e2etests.TestBitcoinStdMemoDepositName,
+			e2etests.TestBitcoinStdMemoDepositAndCallName,
+			e2etests.TestBitcoinStdMemoDepositAndCallRevertName,
+			e2etests.TestBitcoinStdMemoDepositAndCallRevertOtherAddressName,
 			e2etests.TestBitcoinWithdrawSegWitName,
 			e2etests.TestBitcoinWithdrawInvalidAddressName,
 			e2etests.TestZetaWithdrawBTCRevertName,

e2e/e2etests/e2etests.go

@@ -72,18 +72,23 @@ const (
 	 Bitcoin tests
 	 Test transfer of Bitcoin asset across chains
 	*/
-	TestBitcoinDepositName                = "bitcoin_deposit"
-	TestBitcoinDepositRefundName          = "bitcoin_deposit_refund"
-	TestBitcoinDepositAndCallName         = "bitcoin_deposit_and_call"
-	TestBitcoinWithdrawSegWitName         = "bitcoin_withdraw_segwit"
-	TestBitcoinWithdrawTaprootName        = "bitcoin_withdraw_taproot"
-	TestBitcoinWithdrawMultipleName       = "bitcoin_withdraw_multiple"
-	TestBitcoinWithdrawLegacyName         = "bitcoin_withdraw_legacy"
-	TestBitcoinWithdrawP2WSHName          = "bitcoin_withdraw_p2wsh"
-	TestBitcoinWithdrawP2SHName           = "bitcoin_withdraw_p2sh"
-	TestBitcoinWithdrawInvalidAddressName = "bitcoin_withdraw_invalid"
-	TestBitcoinWithdrawRestrictedName     = "bitcoin_withdraw_restricted"
-	TestExtractBitcoinInscriptionMemoName = "bitcoin_memo_from_inscription"
+	TestBitcoinDepositName                                 = "bitcoin_deposit"
+	TestBitcoinDepositAndCallName                          = "bitcoin_deposit_and_call"
+	TestBitcoinDepositAndCallRevertName                    = "bitcoin_deposit_and_call_revert"
+	TestBitcoinDonationName                                = "bitcoin_donation"
+	TestBitcoinStdMemoDepositName                          = "bitcoin_std_memo_deposit"
+	TestBitcoinStdMemoDepositAndCallName                   = "bitcoin_std_memo_deposit_and_call"
+	TestBitcoinStdMemoDepositAndCallRevertName             = "bitcoin_std_memo_deposit_and_call_revert"
+	TestBitcoinStdMemoDepositAndCallRevertOtherAddressName = "bitcoin_std_memo_deposit_and_call_revert_other_address"
+	TestBitcoinWithdrawSegWitName                          = "bitcoin_withdraw_segwit"
+	TestBitcoinWithdrawTaprootName                         = "bitcoin_withdraw_taproot"
+	TestBitcoinWithdrawMultipleName                        = "bitcoin_withdraw_multiple"
+	TestBitcoinWithdrawLegacyName                          = "bitcoin_withdraw_legacy"
+	TestBitcoinWithdrawP2WSHName                           = "bitcoin_withdraw_p2wsh"
+	TestBitcoinWithdrawP2SHName                            = "bitcoin_withdraw_p2sh"
+	TestBitcoinWithdrawInvalidAddressName                  = "bitcoin_withdraw_invalid"
+	TestBitcoinWithdrawRestrictedName                      = "bitcoin_withdraw_restricted"
+	TestExtractBitcoinInscriptionMemoName                  = "bitcoin_memo_from_inscription"
 
 	/*
 	 Application tests
@@ -490,11 +495,50 @@ var AllE2ETests = []runner.E2ETest{
 		TestBitcoinDepositAndCall,
 	),
 	runner.NewE2ETest(
-		TestBitcoinDepositRefundName,
+		TestBitcoinDepositAndCallRevertName,
 		"deposit Bitcoin into ZEVM; expect refund", []runner.ArgDefinition{
 			{Description: "amount in btc", DefaultValue: "0.1"},
 		},
-		TestBitcoinDepositRefund,
+		TestBitcoinDepositAndCallRevert,
+	),
+	runner.NewE2ETest(
+		TestBitcoinDonationName,
+		"donate Bitcoin to TSS address", []runner.ArgDefinition{
+			{Description: "amount in btc", DefaultValue: "0.001"},
+		},
+		TestBitcoinDonation,
+	),
+	runner.NewE2ETest(
+		TestBitcoinStdMemoDepositName,
+		"deposit Bitcoin into ZEVM with standard memo",
+		[]runner.ArgDefinition{
+			{Description: "amount in btc", DefaultValue: "0.1"},
+		},
+		TestBitcoinStdMemoDeposit,
+	),
+	runner.NewE2ETest(
+		TestBitcoinStdMemoDepositAndCallName,
+		"deposit Bitcoin into ZEVM and call a contract with standard memo",
+		[]runner.ArgDefinition{
+			{Description: "amount in btc", DefaultValue: "0.1"},
+		},
+		TestBitcoinStdMemoDepositAndCall,
+	),
+	runner.NewE2ETest(
+		TestBitcoinStdMemoDepositAndCallRevertName,
+		"deposit Bitcoin into ZEVM and call a contract with standard memo; expect revert",
+		[]runner.ArgDefinition{
+			{Description: "amount in btc", DefaultValue: "0.1"},
+		},
+		TestBitcoinStdMemoDepositAndCallRevert,
+	),
+	runner.NewE2ETest(
+		TestBitcoinStdMemoDepositAndCallRevertOtherAddressName,
+		"deposit Bitcoin into ZEVM and call a contract with standard memo; expect revert to other address",
+		[]runner.ArgDefinition{
+			{Description: "amount in btc", DefaultValue: "0.1"},
+		},
+		TestBitcoinStdMemoDepositAndCallRevertOtherAddress,
 	),
 	runner.NewE2ETest(
 		TestBitcoinWithdrawSegWitName,

e2e/e2etests/test_bitcoin_deposit.go

@@ -15,7 +15,7 @@ func TestBitcoinDeposit(r *runner.E2ERunner, args []string) {
 
 	r.SetBtcAddress(r.Name, false)
 
-	txHash := r.DepositBTCWithAmount(depositAmount)
+	txHash := r.DepositBTCWithAmount(depositAmount, nil)
 
 	// wait for the cctx to be mined
 	cctx := utils.WaitCctxMinedByInboundHash(r.Ctx, txHash.String(), r.CctxClient, r.Logger, r.CctxTimeout)

e2e/e2etests/test_bitcoin_deposit_and_call_revert.go

@@ -0,0 +1,51 @@
+package e2etests
+
+import (
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
+	"github.com/zeta-chain/node/e2e/runner"
+	"github.com/zeta-chain/node/e2e/utils"
+	"github.com/zeta-chain/node/testutil/sample"
+	zetabitcoin "github.com/zeta-chain/node/zetaclient/chains/bitcoin"
+)
+
+func TestBitcoinDepositAndCallRevert(r *runner.E2ERunner, args []string) {
+	// ARRANGE
+	// Given BTC address
+	r.SetBtcAddress(r.Name, false)
+
+	// Given "Live" BTC network
+	stop := r.MineBlocksIfLocalBitcoin()
+	defer stop()
+
+	// Given amount to send
+	require.Len(r, args, 1)
+	amount := parseFloat(r, args[0])
+	amount += zetabitcoin.DefaultDepositorFee
+
+	// Given a list of UTXOs
+	utxos, err := r.ListDeployerUTXOs()
+	require.NoError(r, err)
+	require.NotEmpty(r, utxos)
+
+	// ACT
+	// Send BTC to TSS address with a dummy memo
+	// zetacore should revert cctx if call is made on a non-existing address
+	nonExistReceiver := sample.EthAddress()
+	badMemo := append(nonExistReceiver.Bytes(), []byte("gibberish-memo")...)
+	txHash, err := r.SendToTSSFromDeployerWithMemo(amount, utxos, badMemo)
+	require.NoError(r, err)
+	require.NotEmpty(r, txHash)
+
+	// ASSERT
+	// Now we want to make sure refund TX is completed.
+	cctx := utils.WaitCctxRevertedByInboundHash(r.Ctx, r, txHash.String(), r.CctxClient)
+
+	// Check revert tx receiver address and amount
+	receiver, value := r.QueryOutboundReceiverAndAmount(cctx.OutboundParams[1].Hash)
+	assert.Equal(r, r.BTCDeployerAddress.EncodeAddress(), receiver)
+	assert.Positive(r, value)
+
+	r.Logger.Info("Sent %f BTC to TSS with invalid memo, got refund of %d satoshis", amount, value)
+}

e2e/e2etests/test_bitcoin_donation.go

@@ -0,0 +1,44 @@
+package e2etests
+
+import (
+	"time"
+
+	"github.com/stretchr/testify/require"
+
+	"github.com/zeta-chain/node/e2e/runner"
+	"github.com/zeta-chain/node/pkg/constant"
+	crosschaintypes "github.com/zeta-chain/node/x/crosschain/types"
+	zetabitcoin "github.com/zeta-chain/node/zetaclient/chains/bitcoin"
+)
+
+func TestBitcoinDonation(r *runner.E2ERunner, args []string) {
+	// ARRANGE
+	// Given BTC address
+	r.SetBtcAddress(r.Name, false)
+
+	// Given "Live" BTC network
+	stop := r.MineBlocksIfLocalBitcoin()
+	defer stop()
+
+	// Given amount to send
+	require.Len(r, args, 1)
+	amount := parseFloat(r, args[0])
+	amountTotal := amount + zetabitcoin.DefaultDepositorFee
+
+	// Given a list of UTXOs
+	utxos, err := r.ListDeployerUTXOs()
+	require.NoError(r, err)
+	require.NotEmpty(r, utxos)
+
+	// ACT
+	// Send BTC to TSS address with donation message
+	memo := []byte(constant.DonationMessage)
+	txHash, err := r.SendToTSSFromDeployerWithMemo(amountTotal, utxos, memo)
+	require.NoError(r, err)
+
+	// ASSERT after 20 seconds
+	time.Sleep(time.Second * 20)
+	req := &crosschaintypes.QueryInboundHashToCctxDataRequest{InboundHash: txHash.String()}
+	_, err = r.CctxClient.InTxHashToCctxData(r.Ctx, req)
+	require.Error(r, err)
+}

e2e/e2etests/test_bitcoin_std_deposit.go

@@ -0,0 +1,59 @@
+package e2etests
+
+import (
+	"math/big"
+
+	"github.com/ethereum/go-ethereum/accounts/abi/bind"
+	"github.com/stretchr/testify/require"
+
+	"github.com/zeta-chain/node/e2e/runner"
+	"github.com/zeta-chain/node/e2e/utils"
+	"github.com/zeta-chain/node/pkg/memo"
+	crosschaintypes "github.com/zeta-chain/node/x/crosschain/types"
+	"github.com/zeta-chain/node/zetaclient/chains/bitcoin"
+)
+
+func TestBitcoinStdMemoDeposit(r *runner.E2ERunner, args []string) {
+	// setup deployer BTC address
+	r.SetBtcAddress(r.Name, false)
+
+	// parse amount to deposit
+	require.Len(r, args, 1)
+	amount := parseFloat(r, args[0])
+
+	// get ERC20 BTC balance before deposit
+	balanceBefore, err := r.BTCZRC20.BalanceOf(&bind.CallOpts{}, r.EVMAddress())
+	require.NoError(r, err)
+	r.Logger.Info("runner balance of BTC before deposit: %d satoshis", balanceBefore)
+
+	// create standard memo with receiver address
+	memo := &memo.InboundMemo{
+		Header: memo.Header{
+			Version:     0,
+			EncodingFmt: memo.EncodingFmtCompactShort,
+			OpCode:      memo.OpCodeDeposit,
+		},
+		FieldsV0: memo.FieldsV0{
+			Receiver: r.EVMAddress(), // to deployer self
+		},
+	}
+
+	// deposit BTC with standard memo
+	txHash := r.DepositBTCWithAmount(amount, memo)
+
+	// wait for the cctx to be mined
+	cctx := utils.WaitCctxMinedByInboundHash(r.Ctx, txHash.String(), r.CctxClient, r.Logger, r.CctxTimeout)
+	r.Logger.CCTX(*cctx, "bitcoin_std_memo_deposit")
+	utils.RequireCCTXStatus(r, cctx, crosschaintypes.CctxStatus_OutboundMined)
+
+	// get ERC20 BTC balance after deposit
+	balanceAfter, err := r.BTCZRC20.BalanceOf(&bind.CallOpts{}, r.EVMAddress())
+	require.NoError(r, err)
+	r.Logger.Info("runner balance of BTC after deposit: %d satoshis", balanceAfter)
+
+	// the runner balance should be increased by the deposit amount
+	amountIncreased := new(big.Int).Sub(balanceAfter, balanceBefore)
+	amountSatoshis, err := bitcoin.GetSatoshis(amount)
+	require.NoError(r, err)
+	require.Equal(r, uint64(amountSatoshis), amountIncreased.Uint64())
+}