-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: ensure variables are set for cache build #2948
Conversation
📝 WalkthroughWalkthroughThe changes implemented in the pull request enhance the GitHub Actions workflow by introducing new environment variables for the Node.js version and the latest commit hash. A new step, "Set version for cache," has been added to retrieve and set these variables, ensuring consistency during the Docker image build process. Additionally, the Docker build step has been updated to utilize these new variables, improving the caching mechanism while maintaining the overall structure of the workflow. Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧰 Additional context used🪛 actionlint
🔇 Additional comments (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
#2928 introduced these logs in E2E CI:
This is because the cache build also needs to have the version set. But considering it passed all CI it might make sense to just keep the version static in e2e so that build cache performance is improved.
Summary by CodeRabbit
New Features
NODE_VERSION
andNODE_COMMIT
to enhance the caching mechanism during Docker builds.Improvements