feat: backport solana withdraw

[ws4charlie]

Description

Backport Solana withdraw functionality to release/v19

Closes: #2619

How Has This Been Tested?

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

[coderabbitai]

Important

Review skipped

Auto reviews are limited to specific labels.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

!!!WARNING!!!
nosec detected in the following files: cmd/zetaclientd/solana_test_key.go, e2e/e2etests/test_solana_withdraw.go, pkg/contracts/solana/gateway_message_test.go, zetaclient/chains/solana/signer/withdraw.go, e2e/e2etests/test_solana_deposit.go, zetaclient/config/types.go, zetaclient/orchestrator/orchestrator.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

[codecov]

Codecov Report

Attention: Patch coverage is 24.96925% with 610 lines in your changes missing coverage. Please review.

Project coverage is 46.32%. Comparing base (5877780) to head (f9bfa71).

Files	Patch %	Lines
zetaclient/chains/solana/observer/outbound.go	27.74%	123 Missing and 2 partials ⚠️
zetaclient/chains/solana/signer/signer.go	0.00%	70 Missing ⚠️
zetaclient/chains/solana/signer/withdraw.go	0.00%	56 Missing ⚠️
zetaclient/orchestrator/orchestrator.go	37.17%	49 Missing ⚠️
zetaclient/chains/solana/observer/observer_gas.go	0.00%	41 Missing ⚠️
.../chains/solana/signer/outbound_tracker_reporter.go	0.00%	36 Missing ⚠️
zetaclient/chains/bitcoin/observer/outbound.go	3.33%	29 Missing ⚠️
zetaclient/orchestrator/bootstrap.go	24.32%	27 Missing and 1 partial ⚠️
pkg/contracts/solana/gateway_message.go	42.50%	23 Missing ⚠️
e2e/e2etests/test_solana_withdraw.go	0.00%	21 Missing ⚠️
... and 16 more

Additional details and impacted files

@@               Coverage Diff               @@
##           release/v19    #2629      +/-   ##
===============================================
- Coverage        46.80%   46.32%   -0.48%     
===============================================
  Files              465      472       +7     
  Lines            30820    31400     +580     
===============================================
+ Hits             14425    14546     +121     
- Misses           15539    16004     +465     
+ Partials           856      850       -6     

Files	Coverage Δ
x/observer/types/chain_params.go	98.59% <100.00%> (+6.03%)	⬆️
zetaclient/chains/evm/signer/outbound_data.go	71.05% <100.00%> (+3.97%)	⬆️
zetaclient/testutils/testdata.go	83.84% <100.00%> (+0.64%)	⬆️
zetaclient/testutils/testdata_naming.go	78.94% <100.00%> (+1.16%)	⬆️
zetaclient/zetacore/client_vote.go	57.54% <100.00%> (+1.06%)	⬆️
zetaclient/zetacore/tx.go	85.41% <100.00%> (+0.63%)	⬆️
e2e/txserver/zeta_tx_server.go	0.00% <0.00%> (ø)
zetaclient/chains/base/observer.go	84.78% <0.00%> (-0.94%)	⬇️
zetaclient/chains/base/signer.go	95.45% <85.71%> (+8.78%)	⬆️
zetaclient/chains/evm/observer/observer.go	50.95% <77.77%> (ø)
... and 22 more

[swift1337]

Can we also include this PR? #2568 Otherwise release/v19 will diverge a lot from develop

[lumtis]

Can we also include this PR? #2568 Otherwise release/v19 will diverge a lot from develop

We want to limit changes backported to release/v19 to keep the code as close to the last audited version