-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: create base signer and signer structs to group common data of EVM/Bitcoin signer and observer #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ws4charlie
requested review from
brewmaster012,
kingpinXD,
lumtis and
skosito
as code owners
June 17, 2024 15:26
ws4charlie
changed the title
Refactor base signer observer
refactor: create base signer and signer structs to group common data of EVM/Bitcoin signer and observer
Jun 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2344 +/- ##
===========================================
+ Coverage 68.06% 68.37% +0.30%
===========================================
Files 299 302 +3
Lines 18971 19178 +207
===========================================
+ Hits 12913 13112 +199
- Misses 5421 5426 +5
- Partials 637 640 +3
|
lumtis
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few comment regarding documentation
skosito
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactor created three base structs below. The final goal is to use these reusable base structs to simply existing EVM/Bitcoin signers and observers.
Signer
as the base struct for all chain signers.Observer
as the base struct for all chain observers.Logger
struct that contain commonly used loggers by observers.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: