Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add queries ShowAuthorization and ListAuthorizations #2312

Merged
merged 15 commits into from
Jun 6, 2024

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented Jun 4, 2024

Description

Closes: #2307

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Base automatically changed from authorization-list-messages to develop June 4, 2024 17:27
@kingpinXD kingpinXD changed the title feat: queries for authorization list feat: add queries ShowAuthorization and ListAuthorizations Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.30%. Comparing base (5929b51) to head (a6b4c89).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2312      +/-   ##
===========================================
+ Coverage    68.26%   68.30%   +0.04%     
===========================================
  Files          298      299       +1     
  Lines        18880    18905      +25     
===========================================
+ Hits         12888    12913      +25     
  Misses        5355     5355              
  Partials       637      637              
Files Coverage Δ
.../authority/keeper/grpc_query_authorization_list.go 100.00% <100.00%> (ø)

@kingpinXD kingpinXD marked this pull request as ready for review June 4, 2024 18:13
proto/zetachain/zetacore/authority/query.proto Outdated Show resolved Hide resolved
x/authority/keeper/grpc_query_authorization_list.go Outdated Show resolved Hide resolved
x/authority/keeper/grpc_query_authorization_list.go Outdated Show resolved Hide resolved
x/authority/keeper/grpc_query_authorization_list.go Outdated Show resolved Hide resolved
@kingpinXD kingpinXD requested a review from lumtis June 5, 2024 16:01
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Minor comment

x/authority/keeper/grpc_query_authorization_list.go Outdated Show resolved Hide resolved
@kingpinXD kingpinXD merged commit 3f02526 into develop Jun 6, 2024
19 checks passed
@kingpinXD kingpinXD deleted the authorization-list-queries branch June 6, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Queries for authorizations list
3 participants