Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect bitcoin outbound height #2243

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

ws4charlie
Copy link
Contributor

Description

During Bitcoin withdraw tests in Athens3, I noticed an old issue that existed since v1. Looking at this mainnet bitcoin outbound cctx:
https://zetachain.blockpi.network/lcd/v1/public/zeta-chain/crosschain/cctx/8332/200

The cctx's outbound parameter contains a wrong "outbound_tx_observed_external_height": "578", the correct height should be 835053 in bitcoin explorer
image

It is a minor issue that could impact explorer, nothing about security.

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@ws4charlie ws4charlie added bug Something isn't working zetaclient Issues related to ZetaClient labels May 22, 2024
Copy link

!!!WARNING!!!
nosec detected in the following files: zetaclient/chains/bitcoin/observer/outbound.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 67.99%. Comparing base (1302dcc) to head (31a6fc7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2243      +/-   ##
===========================================
- Coverage    68.06%   67.99%   -0.07%     
===========================================
  Files          259      259              
  Lines        16014    16030      +16     
===========================================
  Hits         10900    10900              
- Misses        4653     4669      +16     
  Partials       461      461              
Files Coverage Δ
zetaclient/chains/bitcoin/observer/outbound.go 35.84% <0.00%> (-0.67%) ⬇️
zetaclient/chains/bitcoin/observer/observer.go 14.31% <0.00%> (-0.31%) ⬇️

@ws4charlie ws4charlie merged commit 714beab into develop May 23, 2024
20 of 21 checks passed
@ws4charlie ws4charlie deleted the fix-btc-outbound-height branch May 23, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nosec zetaclient Issues related to ZetaClient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants