Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove duplicate ValidateChainParams function #1863

Merged
merged 6 commits into from
Mar 14, 2024

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Mar 8, 2024

Description

Removing duplicate ValidateChainParams function in zetaclient and using one from observer types, so it is not maintained on 2 places.

Closes: #1838

Type of change

Cleanup

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 49.88%. Comparing base (ae205b5) to head (0f4aa76).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1863   +/-   ##
========================================
  Coverage    49.88%   49.88%           
========================================
  Files          219      219           
  Lines        12712    12712           
========================================
  Hits          6342     6342           
  Misses        5928     5928           
  Partials       442      442           
Files Coverage Δ
zetaclient/zetabridge/zetacore_bridge.go 0.00% <0.00%> (ø)

@lumtis lumtis changed the title chore: remove duplicate ValidateChainParams function refactor: remove duplicate ValidateChainParams function Mar 11, 2024
@lumtis
Copy link
Member

lumtis commented Mar 11, 2024

@skosito renamed FYI, this is a refactor, not a chore. Chore shouldn't not touch the codebase

@lumtis lumtis closed this Mar 11, 2024
@lumtis lumtis reopened this Mar 11, 2024
@skosito skosito merged commit ce26536 into develop Mar 14, 2024
20 of 21 checks passed
@skosito skosito deleted the chore-remove-duplicate-function branch March 14, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate ValidateChainParams in zetaclient
3 participants