-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add unit tests for crosschain evm hooks #1787
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1787 +/- ##
===========================================
+ Coverage 38.41% 39.80% +1.39%
===========================================
Files 206 206
Lines 12584 12586 +2
===========================================
+ Hits 4834 5010 +176
+ Misses 7362 7181 -181
- Partials 388 395 +7
|
@kingpinXD this addresses this one right? #1759 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some comment on the formatting
Co-authored-by: Lucas Bertrand <[email protected]>
Co-authored-by: Lucas Bertrand <[email protected]>
Co-authored-by: Lucas Bertrand <[email protected]>
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me outside of the test failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just couple small comments
Description
Add unit tests for EVM hooks.
Closes: #1759
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: