Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use interface for evm keeper in fungible module #879

Closed
lumtis opened this issue Jul 31, 2023 · 0 comments · Fixed by #900
Closed

Use interface for evm keeper in fungible module #879

lumtis opened this issue Jul 31, 2023 · 0 comments · Fixed by #900
Assignees
@lumtis

Comments

@lumtis
Copy link
Member

lumtis commented Jul 31, 2023

Use an interface EVMKeeper defined in types/expected_keepers.go for the evmKeeper instance in fungible keeper.
This reduces coupling and enables mocking for unit tests of the module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lumtis lumtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(fungible): define interface for EVM keeper reference zeta-chain/node
1 participant
@lumtis