Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a param for message max length of MsgVoteOnObservedInboundTx #862

Closed
lumtis opened this issue Jul 28, 2023 · 0 comments
Closed

Create a param for message max length of MsgVoteOnObservedInboundTx #862

lumtis opened this issue Jul 28, 2023 · 0 comments
Labels
m:crosschain

Comments

@lumtis
Copy link
Member

lumtis commented Jul 28, 2023

node/x/crosschain/types/message_vote_on_observed_inbound_tx.go

Line 64 in 1326c6e

// TODO: should parameterize the hardcoded max len

  • Create a param for the value in the crosschain module
  • Move the verification in the keeper using the param value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
m:crosschain
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fadeev @lumtis