Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write V2 contract E2E tests #2554

Closed
Tracked by #2552
lumtis opened this issue Jul 25, 2024 · 0 comments · Fixed by #2594
Closed
Tracked by #2552

Write V2 contract E2E tests #2554

lumtis opened this issue Jul 25, 2024 · 0 comments · Fixed by #2594
Labels
E2E E2E tests related

Comments

@lumtis
Copy link
Member

lumtis commented Jul 25, 2024

Describe the Issue

We can reimplement same current test with v2_ prefix
We can also consider doing some renaming since we are reimplementing some test

Regarding the call test, I think we can reuse the current testdapp contract used for ZEVM message passing and adapt it for all test (deposit_and_call, withdraw_and_call, simple_call)

  • v2_gas_deposit

  • v2_gas_deposit_call

  • v2_gas_deposit_call_revert

  • v2_gas_deposit_call_abort

  • v2_gas_withdraw

  • v2_gas_withdraw_call

  • v2_gas_withdraw_call_revert

  • v2_gas_withdraw_call_abort

  • v2_erc20_deposit

  • v2_erc20_deposit_call

  • v2_erc20_deposit_call_revert

  • v2_erc20_deposit_call_abort

  • v2_erc20_withdraw

  • v2_erc20_withdraw_call

  • v2_erc20_withdraw_call_revert

  • v2_erc20_withdraw_call_abort

  • v2_zevm_to_evm_call

  • v2_zevm_to_evm_call_revert

  • v2_zevm_to_evm_call_abort

  • v2_evm_to_zevm_call

  • v2_evm_to_zevm_call_revert (not sure this one is possible given no fee to revert)

  • v2_evm_to_zevm_call_abort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E E2E tests related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant