Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing init() usages in zetaclient #2029

Closed
Tracked by #1611
lumtis opened this issue Apr 15, 2024 · 1 comment · Fixed by #3122
Closed
Tracked by #1611

Consider removing init() usages in zetaclient #2029

lumtis opened this issue Apr 15, 2024 · 1 comment · Fixed by #3122
Assignees
@swift1337
Labels
zetaclient Issues related to ZetaClient

Comments

@lumtis
Copy link
Member

lumtis commented Apr 15, 2024

Describe the Issue
Function init() are defined in keyring.go and authz_signer.go.

The packages defined in zetaclient, outside of the cmd should be agnostic to app initialize. These packages should provide an API to initialize values currently in init() that can then be used by the caller.
@lumtis lumtis added the zetaclient Issues related to ZetaClient label Apr 15, 2024
@lumtis lumtis mentioned this issue Apr 15, 2024
Open
@swift1337 swift1337 self-assigned this Nov 6, 2024
@swift1337
Copy link
Contributor

WIP

@swift1337 swift1337 mentioned this issue Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swift1337 swift1337

Labels
zetaclient Issues related to ZetaClient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(zetaclient)!: cli improvements zeta-chain/node
2 participants
@lumtis @swift1337