Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent reading params to panic #1860

Closed
lumtis opened this issue Mar 8, 2024 · 0 comments · Fixed by #1864
Closed

Prevent reading params to panic #1860

lumtis opened this issue Mar 8, 2024 · 0 comments · Fixed by #1864
Assignees
@lumtis
Labels
defensive Defensive programming related
Milestone
v16

Comments

@lumtis
Copy link
Member

lumtis commented Mar 8, 2024

Describe the Issue
Replace usage of Get with GetIfExists to ensure reading params doesn't panic.
Add unit test to ensure no panic
@lumtis lumtis added the defensive Defensive programming related label Mar 8, 2024
@lumtis lumtis self-assigned this Mar 8, 2024
@lumtis lumtis added this to the v15 milestone Mar 8, 2024
@lumtis lumtis mentioned this issue Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lumtis lumtis

Labels
defensive Defensive programming related
Projects
None yet
Milestone
v16
Development

Successfully merging a pull request may close this issue.

refactor: prevent panicking with params zeta-chain/node
1 participant
@lumtis