Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on config/params separation in zetaclient #1807

Closed
Tracked by #1611
skosito opened this issue Feb 26, 2024 · 0 comments · Fixed by #1831
Closed
Tracked by #1611

Follow up on config/params separation in zetaclient #1807

skosito opened this issue Feb 26, 2024 · 0 comments · Fixed by #1831
Assignees
@skosito
Labels
zetaclient Issues related to ZetaClient

Comments

@skosito
Copy link
Contributor

skosito commented Feb 26, 2024

Describe the Issue
There are 2 things that are leftovers from previous solution:

  • check if we can reduce usage of pointers in config/core context
  • add missing tests for core context

For more details check these 2 comments:
#1774 (comment)
#1774 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skosito skosito

Labels
zetaclient Issues related to ZetaClient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: removing unnecessary pointers in context structure zeta-chain/node
2 participants
@lumtis @skosito