Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Setting Brightness appears to reset the settings #342

Closed
SilkyPants opened this issue Mar 17, 2022 · 1 comment · Fixed by #345
Closed

[BUG] Setting Brightness appears to reset the settings #342

SilkyPants opened this issue Mar 17, 2022 · 1 comment · Fixed by #345
Assignees
Labels
bug Something isn't working

Comments

@SilkyPants
Copy link

Platform

Web

Steps to Reproduce

  1. Open app, notice Brightness setting
  2. Set Seed colour to anything, notice state updates
  3. Change Brightness setting
  4. Notice settings are reset to default colours (seed color stays the same)
  5. Change Brightness setting back to the original setting
  6. Notice settings are reset to default colours (seed color stays the same)

Expected behaviour

Seed color changes should persist between brightness settings

Actual behaviour

Seed color changes do not persist between brightness settings, and appear to reset to default colors

Additional Context

No response

@SilkyPants SilkyPants added the bug Something isn't working label Mar 17, 2022
@zeshuaro
Copy link
Owner

Hey @SilkyPantsDan, thanks for raising this issue. It is the intended behaviour for the properties to reset when you toggle the brightness, as some of them need to be updated to fit with the brightness. And so it seems like there is a bug with the seed colour not being reset.

To improve the user experience, perhaps I can add a warning when users decide to toggle the brightness that them properties will be reset.

@zeshuaro zeshuaro self-assigned this Mar 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants