Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JDK8 and add java.nio.Path support #105

Open
andresluuk opened this issue Jun 28, 2018 · 5 comments
Open

Update to JDK8 and add java.nio.Path support #105

andresluuk opened this issue Jun 28, 2018 · 5 comments

Comments

@andresluuk
Copy link

andresluuk commented Jun 28, 2018

In one of our applications we are updating Files to Path-s, but this library only accepts File.

We should add a Parallel API for Path support. Also maybe deprecate the File methods? I would not remove them, for backwards compatibility.

Because Path is introduced in JDK7 we must upgrade the JDK also. I would upgrade to JDK8 because 7 isn't used much and that would allow us to use JDK8 features.

@toomasr
Copy link
Contributor

toomasr commented Jun 28, 2018

Sounds good. Let's add the Path equivalent methods. As File isn't deprecated in the JDK we should not either. Bumping the minimum version to Java 8 makes sense!

@eku
Copy link

eku commented Jul 2, 2018

Will this break compatibility with Android?

@toomasr
Copy link
Contributor

toomasr commented Jul 2, 2018

@eku great question, I'll check with our local Android gurus.

@eku
Copy link

eku commented Aug 6, 2018

@toomasr did you check with your local Android gurus?

@toomasr
Copy link
Contributor

toomasr commented Aug 7, 2018

Yup and the feedback was to just maintain the latest good version for Android. I think this is good enough. Once the jdk8 branch lands we'll figure out the versioning. Probably we'll release the Path approach as 2.0 and make sure that 1.x is Android compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants