Build fails on linux

[tanevanwifferen]

Describe the bug
Can't get my project to work anymore. It used to build fine, but doesn't anymore. Not sure what happened in the mean time.

The compile log has some weird issues that I am not familiar with, in the past I used to be able to use prebuilt binaries.

../binding.cc: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE zmq::Socket::Sendv(Nan::NAN_METHOD_ARGS_TYPE)’:
../binding.cc:1300:39: error: no matching function for call to ‘v8::Array::Get(uint32_t&)’
 1300 |       Local<Object> buf = batch->Get(i).As<Object>();
      |                                       ^
In file included from ../binding.cc:24:
/home/tane/.node-gyp/13.1.0/include/node/v8.h:3471:43: note: candidate: ‘v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, v8::Local<v8::Value>)’
 3471 |   V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
      |                                           ^~~
/home/tane/.node-gyp/13.1.0/include/node/v8.h:3471:43: note:   candidate expects 2 arguments,
1 provided
/home/tane/.node-gyp/13.1.0/include/node/v8.h:3474:43: note: candidate: ‘v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, uint32_t)’
 3474 |   V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
      |                                           ^~~
/home/tane/.node-gyp/13.1.0/include/node/v8.h:3474:43: note:   candidate expects 2 arguments,
1 provided
../binding.cc:1300:50: error: expected primary-expression before ‘>’ token
 1300 |       Local<Object> buf = batch->Get(i).As<Object>();
      |                                                  ^
../binding.cc:1300:52: error: expected primary-expression before ‘)’ token
 1300 |       Local<Object> buf = batch->Get(i).As<Object>();
      |                                                    ^
../binding.cc:1301:48: error: no matching function for call to ‘v8::Array::Get(uint32_t)’
 1301 |       Local<Number> flagsObj = batch->Get(i + 1).As<Number>();
      |                                                ^
In file included from ../binding.cc:24:
/home/tane/.node-gyp/13.1.0/include/node/v8.h:3471:43: note: candidate: ‘v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, v8::Local<v8::Value>)’
 3471 |   V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
      |                                           ^~~
/home/tane/.node-gyp/13.1.0/include/node/v8.h:3471:43: note:   candidate expects 2 arguments,
1 provided
/home/tane/.node-gyp/13.1.0/include/node/v8.h:3474:43: note: candidate: ‘v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, uint32_t)’
 3474 |   V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
      |                                           ^~~
/home/tane/.node-gyp/13.1.0/include/node/v8.h:3474:43: note:   candidate expects 2 arguments,
1 provided
../binding.cc:1301:59: error: expected primary-expression before ‘>’ token
 1301 |       Local<Number> flagsObj = batch->Get(i + 1).As<Number>();
      |                                                           ^
../binding.cc:1301:61: error: expected primary-expression before ‘)’ token
 1301 |       Local<Number> flagsObj = batch->Get(i + 1).As<Number>();
      |                                                             ^

Reproducing

• Clone https://github.com/tanevanwifferen/TangleChat
• npm install

Expected behavior
I guess it works on your machine, I get the errors.

Tested on

• target=13.1.0 runtime=node arch=x64
  platform=linux
• machine: hp elitebook 8570w
• OS: Arch Linux
• ZeroMQ.js version: 4.3.2-1? That's what my package manager tells me

[rolftimmermans]

Is it possible you are trying with a newer Node.js version now? From your report I understand you are attempting to build with Node.js 13. There is an open PR #348 for Node.js 13 support on the 5.x branch.

You could consider using the 6.0 beta version, it already has Node.js 13 support. The API has changed fundamentally from version 5 to 6, but you can use the compatibility layer to facilitate upgrading.

Hope this helps. If you run into any other problems, feel free to comment here or open a new issue!