Skip to content
This repository has been archived by the owner on Nov 22, 2020. It is now read-only.

Properly fixing the render on scroll issue #161

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

The24thDS
Copy link
Contributor

  • Moving the scroll function back to index.html

Copy link
Member

@MattCSmith MattCSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on catching this issue and researching the issue.

Moving the scroll function back to the index.html file to prevent re-rendering issue seems like the ideal fix 👍

@MattCSmith MattCSmith merged commit 355f5df into zeroDevs:master Jan 25, 2019
@MattCSmith
Copy link
Member

@all-contributors please add @The24thDS for bug

@allcontributors
Copy link
Contributor

@MattCSmith

I've put up a pull request to add @The24thDS! 🎉

@The24thDS
Copy link
Contributor Author

@all-contributors please add @mikeattara for ideas
@all-contributors please add @The24thDS for code

@allcontributors
Copy link
Contributor

@The24thDS

I could not determine your intention.

Basic usage: @all-contributors please add @jakebolam for code, doc and infra

For other usage see the documentation

@The24thDS
Copy link
Contributor Author

@all-contributors please add @mikeattara for ideas, code

@allcontributors
Copy link
Contributor

@The24thDS

I've put up a pull request to add @mikeattara! 🎉

@The24thDS
Copy link
Contributor Author

@all-contributors please add @AkinAguda for bug

@allcontributors
Copy link
Contributor

@The24thDS

I've put up a pull request to add @AkinAguda! 🎉

@The24thDS
Copy link
Contributor Author

@all-contributors please add @MattCSmith for bug

@allcontributors
Copy link
Contributor

@The24thDS

I've put up a pull request to add @MattCSmith! 🎉

@The24thDS
Copy link
Contributor Author

@all-contributors please add @Feythelus for bug, code

@allcontributors
Copy link
Contributor

@The24thDS

I've put up a pull request to add @Feythelus! 🎉

@jakebolam
Copy link
Contributor

jakebolam commented Jan 25, 2019

Thanks for this! (We should totally have support for adding lots of users at once). I have added a ticket to support bulk adding users in a single message: all-contributors/app#100

@The24thDS The24thDS added the all-contributors Added to contributors label Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
all-contributors Added to contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants