fix: [audit] ZNS-18 Approved Resolvers List #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we handle the string key in registration
WIP ZNS-18 from audit
🚨 Vulnerabilities Summary
For more details view the full report in OpenZeppelin Code |
JamesEarle
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #68 +/- ##
============================================
Coverage 99.79% 99.80%
============================================
Files 11 11
Lines 498 502 +4
Branches 124 124
============================================
+ Hits 497 501 +4
Misses 1 1 |
jtulloch
approved these changes
Nov 3, 2023
|
🎉 This PR is included in version 0.6.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add security by only letting approved resolvers be used in domain registration. So far there is a mapping thats
string => addressthat will hold the string key of that specific resolver type e.g.addressand the address of the approved resolver contract it points to. We will be able to expand on the list of resolvers in the future by using theaddResolverTypefunctionality.As a result of this mapping, the
ZNSRootRegistrarno longer needs to have a storage variable specifically for the address resolver. Instead, when we make a domain record that has a resolver, we get the resolver from that mapping and call to its set function.