Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

Improve checks for migratable methods when throwing warnings #165

Open
spalladino opened this issue May 17, 2018 · 0 comments
Open

Improve checks for migratable methods when throwing warnings #165

spalladino opened this issue May 17, 2018 · 0 comments
Labels
kind:enhancement An upgrade or a new feature that improves the system topic:tools Off-chain tooling in general
Milestone

Comments

@spalladino
Copy link
Contributor

spalladino commented May 17, 2018

In #164 we are checking if there are methods called initialize or migrate from the CLI, and showing a warning if they are not called when creating or upgrading a proxy.

A more accurate check if to test if the contract extends from Initializable or Migratable, and detect if any method has the isInitializer or isMigrate modifier. For the latter, we should also check whether the method needs to be called at all, or corresponds to a previous migration already invoked. It could also be the case that an upgrade operation introduces an initializer.

Note that this is subject to actually keep using Migratable. If we switch to standalone-contract-migrations, then this issue can be closed.

@spalladino spalladino added kind:enhancement An upgrade or a new feature that improves the system topic:tools Off-chain tooling in general labels May 17, 2018
@spalladino spalladino added this to the v0.2.0 milestone May 17, 2018
@facuspagnuolo facuspagnuolo modified the milestone: Backlog Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind:enhancement An upgrade or a new feature that improves the system topic:tools Off-chain tooling in general
Projects
None yet
Development

No branches or pull requests

2 participants