This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
Improve checks for migratable methods when throwing warnings #165
Labels
kind:enhancement
An upgrade or a new feature that improves the system
topic:tools
Off-chain tooling in general
Milestone
In #164 we are checking if there are methods called
initialize
ormigrate
from the CLI, and showing a warning if they are not called when creating or upgrading a proxy.A more accurate check if to test if the contract extends from
Initializable
orMigratable
, and detect if any method has theisInitializer
orisMigrate
modifier. For the latter, we should also check whether the method needs to be called at all, or corresponds to a previous migration already invoked. It could also be the case that anupgrade
operation introduces an initializer.Note that this is subject to actually keep using
Migratable
. If we switch to standalone-contract-migrations, then this issue can be closed.The text was updated successfully, but these errors were encountered: