-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soc: nordic: enable DPPI and PPIB nodes by default #82254
Open
e-rk
wants to merge
2
commits into
zephyrproject-rtos:main
Choose a base branch
from
e-rk:dppi-status-okay
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
November 28, 2024 13:33
ankuns
previously approved these changes
Nov 28, 2024
anangl
previously approved these changes
Nov 29, 2024
The UART_xyz_ENHANCED_POLL_OUT Kconfig was using an outdated property for checking whether the peripheral has the endtx->stoptx short. The property is now updated. Signed-off-by: Rafał Kuźnia <[email protected]>
The DPPI and PPIB peripheral nodes must be enabled to allow the CONFIG_HAS_HW_NRF_DPPIC to be set. This change is consistent with what was done on nRF5340 and does not introduce any additional memory overhead, because there is no Zephyr driver behind the nrf-dppic and nrf-ppib bindings. Signed-off-by: Rafał Kuźnia <[email protected]>
e-rk
force-pushed
the
dppi-status-okay
branch
from
November 29, 2024 09:18
01d2544
to
3137f13
Compare
This change uncovered one bug in Kconfig depends statements. The fix was added. |
anangl
approved these changes
Nov 29, 2024
ankuns
approved these changes
Nov 29, 2024
masz-nordic
approved these changes
Nov 29, 2024
piotrkoziar
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DPPI and PPIB peripheral nodes must be enabled to allow the CONFIG_HAS_HW_NRF_DPPIC to be set. This change is consistent with what was done on nRF5340 and does not introduce any additional memory overhead, because there is no Zephyr driver behind the nrf-dppic and nrf-ppib bindings.