drivers: ieee802154: New API for modulated carrier wave transmission. #82134
Conversation
canisLupus1313
requested review from
maciejbaczmanski,
ankuns and
edmont
and removed request for
ankuns
zephyrbot
requested review from
anangl,
cfriedt,
jaz1-nordic,
jukkar,
kl-cruz,
magp-nordic,
masz-nordic,
nika-nordic and
rlubos
| @@ -1786,6 +1786,29 @@ struct ieee802154_radio_api { | |||
| */ | |||
| int (*continuous_carrier)(const struct device *dev); | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
It might be good to surround this with a Kconfig, if it is not normally available during regular device operation.
There was a problem hiding this comment.
@cfriedt Both continuous_carrier and modulated_carrier on the nRF platform driver require extra Kconfig CONFIG_NRF_802154_CARRIER_FUNCTIONS but I don't see why other platforms would have to follow the same logic. So I would prefer to leave it as is.
There was a problem hiding this comment.
Why not simply have a generic carrier Kconfig option here and apply the same one in the Nordic driver (or both?)
Additional reasons:
why expose a NULL function pointer to API consumers?
If a device isn't built for test and is never intended to transmit CW, then code won't accidentally compile or call it, or worse, make that functionality available in the field, possibly jamming other devices?
Zephyr should be minimal by default
There was a problem hiding this comment.
Please take a look at updated version.
canisLupus1313
dismissed stale reviews from rlubos, ankuns, and maciejbaczmanski
via
2b21f9a
canisLupus1313
force-pushed
the
mod_carrier
branch
from
8a6b3ca
to
2b21f9a
Compare
canisLupus1313
force-pushed
the
mod_carrier
branch
from
2b21f9a
to
e8a5e0e
Compare
canisLupus1313
force-pushed
the
mod_carrier
branch
from
e8a5e0e
to
a4974e4
Compare
Added new API function to start modulated carrier wave transmission Signed-off-by: Przemyslaw Bida <[email protected]>
canisLupus1313
force-pushed
the
mod_carrier
branch
from
a4974e4
to
bcf2ba6
Compare
| @@ -204,7 +204,7 @@ config NRF_802154_SECURITY_KEY_STORAGE_SIZE | |||
|
|
|||
| config NRF_802154_CARRIER_FUNCTIONS | |||
| bool "nRF 802.15.4 carrier functions" | |||
| default y if OPENTHREAD_DIAG | |||
| default y if (OPENTHREAD_DIAG || IEEE802154_CARRIER_FUNCTIONS) | |||
There was a problem hiding this comment.
as OPENTHREAD_DIAG now depends on IEEE802154_CARRIER_FUNCTIONS isn't this or statement redundant? We will never have a situation when diag is enabled but carrier functions is disabled. so maybe just default y if IEEE802154_CARRIER_FUNCTIONS would be enough?
Added new API function to start modulated carrier wave transmission