-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-M: increase default Mbed TLS heap size in TF-M #81869
base: main
Are you sure you want to change the base?
Conversation
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Since GH did not automatically assigned reviewers to this PR, I manually added @ithinuel, @tomi-font, @d3zd3z, @Vge0rge as reported in the |
So, this seems reasonable, at least as far as RSA goes, but do you know where the requirement for RSA at all is coming from? |
If you meant "who is willing to use RSA signatures with 2048-bits" then I was notified by this issue #79864. Instead if your question was more like "why RSA needs so much heap memory", it's because TF-M uses Mbed TLS in its crypto partition to perform crypto operations and there RSA uses heap memory a lot (through Luckily the TF-M team already spotted this issue recently and they already had a fix for it, so it was quite easy for me to cherry-pick the fix from them. @d3zd3z did I answered your question? |
d8da7b7
8cc2165
to
d8da7b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change at least the title of the commit to be more explicit about what this is for than update reference
.
d8da7b7
to
84e11f8
Compare
Update TF-M reference to include a couple of commits which are useful to properly size the stack & heap memory for Mbed TLS in order to handle RSA signatures with 2048-bits (previously only 1024-bits were possible). Signed-off-by: Valerio Setti <[email protected]>
84e11f8
to
98e6ea8
Compare
I had to rebase to solve a conflict on |
This PR updates the TF-M reference in to include a couple of commits which are useful to properly size the heap memory allocated in TF-M for the crypto partition. This is necessary in order to allow Mbed TLS to handle RSA signatures with 2048-bits (previously only 1024-bits were possible).
Resolves #79864