Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc: nordic: nrf54l: integrate normal voltage mode fixes #78643

Conversation

nika-nordic
Copy link
Collaborator

MDK 8.67.0 deprecates normal voltage mode for nRF54L, so it should no longer be used by the end users.

@zephyrbot
Copy link
Collaborator

zephyrbot commented Sep 18, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nordic DNM This PR should not be merged (Do Not Merge) labels Sep 18, 2024
nika-nordic added a commit to nika-nordic/sdk-zephyr that referenced this pull request Sep 18, 2024
…f54l fixes

Updated hal_nordic revision contains MDK fixes for nRF54L devices.

Upstream PR: zephyrproject-rtos/zephyr#78643

Signed-off-by: Nikodem Kastelik <[email protected]>
nika-nordic added a commit to nika-nordic/sdk-zephyr that referenced this pull request Sep 18, 2024
Normal voltage mode is no longer supported by MDK 8.67.0.

Upstream PR: zephyrproject-rtos/zephyr#78643

Signed-off-by: Nikodem Kastelik <[email protected]>
Comment on lines 83 to 85
select DEPRECATED
help
This mode is deprecated and shall no longer be used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth deprecating on socs in the engineering phase?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, if deprecating functionality should be kept, and soc.c code is deleted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth deprecating on socs in the engineering phase?

Having this option enabled can be actually harmful when MDK 8.67.0 (nrfx 3.7.0) is used, so let's remove it instead of deprecating

nika-nordic added a commit to nika-nordic/sdk-zephyr that referenced this pull request Sep 18, 2024
Normal voltage mode fix is part of MDK 8.67.0.

Upstream PR: zephyrproject-rtos/zephyr#78643

Signed-off-by: Nikodem Kastelik <[email protected]>
nika-nordic added a commit to nika-nordic/sdk-zephyr that referenced this pull request Sep 18, 2024
Normal voltage mode fix is part of MDK 8.67.0.

Upstream PR: zephyrproject-rtos/zephyr#78643

Signed-off-by: Nikodem Kastelik <[email protected]>
Normal voltage mode is no longer supported by MDK 8.67.0.

Signed-off-by: Nikodem Kastelik <[email protected]>
@nika-nordic nika-nordic force-pushed the integrate_system_nrf54l_mdk_8_67_0_zephyrupstream branch from 7337f9c to 243111c Compare October 9, 2024 06:45
@zephyrbot zephyrbot removed manifest manifest-hal_nordic DNM This PR should not be merged (Do Not Merge) labels Oct 9, 2024
nika-nordic added a commit to nika-nordic/sdk-zephyr that referenced this pull request Oct 14, 2024
Normal voltage mode is no longer supported by MDK 8.67.0.

Upstream PR: zephyrproject-rtos/zephyr#78643

Signed-off-by: Nikodem Kastelik <[email protected]>
(cherry picked from commit 243111c25d712a4fb426a6ddd86ee7814a713131)
@nashif nashif merged commit 6300e1b into zephyrproject-rtos:main Oct 15, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: nRF Nordic nRFx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants