-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: arduino_due: Added DTS to the Arduino Due. #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few minor changes.
dts/arm/arduino_due.dts
Outdated
|
||
/ { | ||
model = "Arduino Due with an Atmel SAM3X8E"; | ||
compatible = "atmel,sam3x"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compatible = "arduino,due", "atmel,sam3x", "atmel,sam3x8e";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the ordering important here, even if by convention? From most specific to the most generic it would be compatible = "arduino,due", "atmel,sam3x8e", "atmel,sam3x";
then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Devicetree v0.1-20160524 spec says, "The property value consists of a concatenated list of null terminated strings, from most specific to most general (page 14)." Therefore I think pfalcon has them in the correct order. At this point I'm going to change it to the order pfalcon listed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, my order wasn't probably the best.
@@ -32,6 +28,12 @@ config SYS_CLOCK_HW_CYCLES_PER_SEC | |||
int | |||
default 84000000 | |||
|
|||
config NUM_IRQ_PRIO_BITS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the only SAM3X board is the Arduino Due, lets just remove the !HAS_DTS bits (which means you can remove config NUM_IRQ_PRIO_BITS, config FLASH_BASE_ADDRESS, etc)
Signed-off-by: Kumar Gala <[email protected]>
Change-Id: I006f9d4080a1351534ede5cc601e43526c39aa83 Origin: Original Signed-off-by: Justin Watson <[email protected]>
[jsrunner] Remove functionality replaced by make
Change-Id: I006f9d4080a1351534ede5cc601e43526c39aa83
Origin: Original
Signed-off-by: Justin Watson [email protected]