Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: arduino_due: Added DTS to the Arduino Due. #59

Closed
wants to merge 2 commits into from

Conversation

fallrisk
Copy link
Collaborator

@fallrisk fallrisk commented May 3, 2017

Change-Id: I006f9d4080a1351534ede5cc601e43526c39aa83
Origin: Original
Signed-off-by: Justin Watson [email protected]

Copy link
Collaborator

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor changes.


/ {
model = "Arduino Due with an Atmel SAM3X8E";
compatible = "atmel,sam3x";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compatible = "arduino,due", "atmel,sam3x", "atmel,sam3x8e";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the ordering important here, even if by convention? From most specific to the most generic it would be compatible = "arduino,due", "atmel,sam3x8e", "atmel,sam3x"; then.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devicetree v0.1-20160524 spec says, "The property value consists of a concatenated list of null terminated strings, from most specific to most general (page 14)." Therefore I think pfalcon has them in the correct order. At this point I'm going to change it to the order pfalcon listed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my order wasn't probably the best.

@@ -32,6 +28,12 @@ config SYS_CLOCK_HW_CYCLES_PER_SEC
int
default 84000000

config NUM_IRQ_PRIO_BITS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the only SAM3X board is the Arduino Due, lets just remove the !HAS_DTS bits (which means you can remove config NUM_IRQ_PRIO_BITS, config FLASH_BASE_ADDRESS, etc)

@galak galak self-assigned this May 3, 2017
Change-Id: I006f9d4080a1351534ede5cc601e43526c39aa83
Origin: Original
Signed-off-by: Justin Watson <[email protected]>
@fallrisk fallrisk closed this May 4, 2017
@fallrisk fallrisk deleted the sam3dts branch May 4, 2017 15:21
@fallrisk fallrisk restored the sam3dts branch May 4, 2017 15:21
@fallrisk fallrisk deleted the sam3dts branch May 4, 2017 15:24
nagineni pushed a commit to nagineni/zephyr that referenced this pull request Nov 20, 2017
[jsrunner] Remove functionality replaced by make
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants