Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

board stm3210c_eval openocd cfg file #37

Closed
wants to merge 0 commits into from
Closed

board stm3210c_eval openocd cfg file #37

wants to merge 0 commits into from

Conversation

kontais
Copy link
Contributor

@kontais kontais commented May 2, 2017 •
edited by galak
Loading

boards/arm/stm3210c_eval/support/openocd.cfg
board/st3210c_eval.cfg -> board/stm3210c_eval.cfg

This change is Reviewable

erwango
erwango requested changes May 2, 2017
View reviewed changes
Copy link
Member

@erwango erwango left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kontais,

Thanks for this contribution.
Your commit is blocked by CI checks.
You should add your sign-off to the commit message.
This will help CI to go fruther

@galak galak self-assigned this May 2, 2017
@kontais kontais closed this May 2, 2017
@xiaoliang314 xiaoliang314 mentioned this pull request Jun 17, 2019
Closed
@xiaoliang314 xiaoliang314 mentioned this pull request Jun 26, 2019
Closed
pabigot added a commit to pabigot/zephyr that referenced this pull request Nov 2, 2019
@pabigot
DNM: demonstrate failures with devicetree multiple compatibles
4ba0dad 
Add specific compatible to existing JEDEC SPI device.

Add a second JEDEC SPI device with a different compatible.

Demonstrates issues with checkpatch:

    -:27: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "mxicy,mx25r6435f" appears un-documented -- check ./dts/bindings/
    zephyrproject-rtos#27: FILE: boards/arm/nrf52840_pca10056/nrf52840_pca10056.dts:195:
    +  compatible = "mxicy,mx25r6435f", "jedec,spi-nor";

    -:37: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "mxicy,mx25l3233f" appears un-documented -- check ./dts/bindings/
    zephyrproject-rtos#37: FILE: boards/arm/nrf52840_pca10056/nrf52840_pca10056.dts:207:
    +  compatible = "mxicy,mx25l3233f", "jedec,spi-nor";

Demonstrates inability to relate specific to generic variant by prefix:

    #define DT_INST_0_MXICY_MX25R6435F  1
    #define DT_INST_0_JEDEC_SPI_NOR     1
    #define DT_INST_0_MXICY_MX25L3233F  1
    #define DT_INST_1_JEDEC_SPI_NOR     1

Signed-off-by: Peter Bigot <[email protected]>
@piotrParf piotrParf mentioned this pull request Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwango erwango erwango requested changes

Assignees

@galak galak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kontais @erwango @galak