drivers: ethernet: sam_gmac: rework pin config #24870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galak
requested review from
jukkar,
nandojve,
pfalcon and
tbursztyka
as code owners
galak
added
area: Devicetree
area: Ethernet
platform: Microchip SAM
61 tasks
nandojve
requested changes
May 1, 2020
galak
force-pushed
the
dt-sam-gmac-pin
branch
2 times, most recently
from
a92eadf to
2ea6e35
Compare
stephanosio
approved these changes
May 2, 2020
nandojve
requested changes
May 2, 2020
There was a problem hiding this comment.
It is missing gtx3 pin and I need rename GCRSDV to GRXDV to be consistent with pin out.
fix_gmac_sam4e_dtsi.txt
With this we can move forward.
Reworked sam_gmac driver to get pin ctrl/mux configuration information from the device tree instead of via Kconfig and defines in soc_pinmap.h We remove defines from soc_pinmap.h that are no longer needed due to getting all that information from devicetree. Signed-off-by: Kumar Gala <[email protected]>
Thanks. Fixed. |
nandojve
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked sam_gmac driver to get pin ctrl/mux configuration information
from the device tree instead of via Kconfig and defines in soc_pinmap.h
We remove defines from soc_pinmap.h that are no longer needed due to
getting all that information from devicetree.
Signed-off-by: Kumar Gala [email protected]