devicetree: atmel sam0: Convert UART to DT_INST and full devicetree #24572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galak
added
area: Devicetree
platform: Microchip SAM
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
This was referenced Apr 21, 2020
Add support for the GCLK, MCLK, and PM clock controllers. Add bindings and devicetree nodes associated with these clock controllers. Also add clock references for the SERCOM peripheral set to allow those drivers (i2c, spi, uart) to utilize this information. Signed-off-by: Kumar Gala <[email protected]>
Move the atmel,sam0-dmac binding under the dma binding dir and add cell information for channel and trigger source. Update the associated dtsi files to match these changes. This is in prep of ATMEL SAM0 SERCOMM devices like UART, I2C, and SPI to user proper 'dmas' property to specify the dma info to use. Signed-off-by: Kumar Gala <[email protected]>
Add a common header for SAM0 drivers to use to extract data from devicetree. The initial set of macros are for get the MCLK A*MASK register address for clock enablement and a set of macros for use with DMA to get the channel and trigger source or 0xff if there is no dmas property. Signed-off-by: Kumar Gala <[email protected]>
Rework the devicetree to utilize new DT_INST macros and extract per instance data for clocks and dma from devicetree. We update the atmel,sam0-uart binding for dma to replace the rxdma and txdma properties with proper 'dmas' property. Signed-off-by: Kumar Gala <[email protected]>
|
Verified working on SAM E54. |
stephanosio
approved these changes
Apr 22, 2020
This was referenced Apr 22, 2020
nandojve
approved these changes
Apr 23, 2020
| trigger source. | ||
|
|
||
| For example dmas for TX, RX on SERCOM3 | ||
| dmas = <&dmac 0 0xb>, <&dmac 0 0xa>; |
There was a problem hiding this comment.
I think important add MCU model when given example. For SAMR21 SERCOM3 triggers are 0x8 and 0x7.
Not sure about dma channels, but I believe should be 1 and 0, for instance.
For example the MCU xxxx dmas for TX, RX on SERCOM3
dmas = <&dmac 1 0xb>, <&dmac 0 0xa>;
|
I tested normal UART with SAMD20 and SAMR21 using shell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add clock support for MCLK, GCLK, and PM to allow SAM0 drivers to be full devicetree based. Also move to proper dma devicetree support.