drivers: hwinfo: update NXP platforms for byte order consistency #24271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resources indicate that CFG2 holds the upper 32 bits, and CFG1 the lower 32 bits, of a 64-bit unique identifier. Store it in big-endian format so it reads correctly when accessed as a byte sequence. https://community.nxp.com/docs/DOC-94459 Signed-off-by: Peter Bigot <[email protected]>
Following the practice for i.MX decoding assume the 32-bit identifier values need to be converted to big-endian representation for device-independent interpretation. Signed-off-by: Peter Bigot <[email protected]>
pabigot
force-pushed
the
nordic/20200410/hwinfo-nxp
branch
from
83e745f to
6a7ce8d
Compare
alexanderwachter
approved these changes
Apr 11, 2020
| if (length > sizeof(dev_id.id)) { | ||
| length = sizeof(dev_id.id); | ||
| if (length > sizeof(id)) { | ||
| length = sizeof(id); |
There was a problem hiding this comment.
I wonder why i didn‘t used the MIN() macro in any of the drivers.
carlescufi
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert 32-bit values to big-endian representation for device-independent interpretation.